Replace forEach with for loop in runStringHandlers #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymostech
suggested changes
Mar 6, 2017
src/generate.js
Outdated
| Object.keys(declarations).forEach(key => { | ||
| const hasStringHandlers = !!stringHandlers; | ||
| const keys = Object.keys(declarations); | ||
| for (var i = 0; i < keys.length; i += 1) { |
There was a problem hiding this comment.
let i = 0 maybe? Is that slower?
There was a problem hiding this comment.
Oops! Should be the same speed, since I think babel compiles it down to var. I think all of the error checking related to the block scoping happens at build time.
According to my profiling, this seems to make runStringHandlers about 10% faster.
Profiling in Chrome shows that moving this out of the loop makes this function ~30% faster.
0e2d679 to
5832b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my profiling, this seems to make runStringHandlers about
10% faster.