Support multiple animation names #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated the `animationName` handler to accept arrays of animation names * Added an example showcasing two asynchronous animations * Updated documentation to include info about single and multiple animations.
|
Hey @joshwcomeau, Thanks for the PR! Mind signing our Contributor License Agreement? When you've done so, go ahead and comment Yours truly, |
|
[clabot:check] |
|
CLA signature looks good 👍 |
|
This all looks great to me! I'll let @jlfwong give it a look before we merge. |
|
LGTM! Thanks @joshwcomeau! Implementation simple and clean, with docs + tests ❤️ @xymostech Can you merge and push a new minor release to npm? |
|
@jlfwong done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
animationNamehandler to accept arrays of animationnames
animations.