Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ts-proto to v1.176.0 and prevent to write version comment #1215

Merged
merged 2 commits into from
May 20, 2024

Conversation

Kesin11
Copy link
Owner

@Kesin11 Kesin11 commented May 20, 2024

fix: #1211

ts-proto starts writing comment headers from v1.174.0. This will cause the diff check to fail on every ts-proto update. #1198
To avoid this problem, add an option to prevent writing proto toolchains version to the comment headers.
stephenh/ts-proto#1040

@Kesin11 Kesin11 added dependencies Pull requests that update a dependency file ci Fix only CI labels May 20, 2024
@Kesin11 Kesin11 changed the base branch from renovate/ts-proto-1.x to master May 20, 2024 15:28
@Kesin11 Kesin11 merged commit 0f939e1 into master May 20, 2024
9 checks passed
@Kesin11 Kesin11 deleted the bump_ts_proto_1_176 branch May 20, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Fix only CI dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant