Feat/199 unpublished doc versions published #209
Conversation
| @@ -261,7 +291,7 @@ protected override IEnumerable<IUmtModel> MapInternal(CmsTreeMapperSource source | |||
| { | |||
| documentModifiedByUserGuid = modifiedByUserGuid; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I think this whitespace was not intended.
| { DocumentPublishedVersionHistoryID: null, DocumentCheckedOutVersionHistoryID: null } => VersionStatus.Published, | ||
| { DocumentPublishedVersionHistoryID: { } pubId, DocumentCheckedOutVersionHistoryID: { } chId } when pubId <= chId => VersionStatus.Published, | ||
| { DocumentPublishedVersionHistoryID: null, DocumentCheckedOutVersionHistoryID: not null } => VersionStatus.InitialDraft, | ||
| _ => draftMigrated ? VersionStatus.Published : VersionStatus.InitialDraft | ||
| }; | ||
|
|
||
| DateTime? scheduledPublishWhen = null; | ||
| DateTime? scheduleUnpublishWhen = null; | ||
| if (cmsDocument.DocumentPublishFrom is { } publishFrom) |
There was a problem hiding this comment.
Separate this condition block from the rest of the code above with blank line
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| using CMS.ContentEngine; | |||
| using CMS.ContentEngine.Internal; | |||
| using CMS.Core; | |||
| using CMS.Core.Internal; | |||
There was a problem hiding this comment.
Integrating the *.Internal API is not a best practice. This API is not officially supported, and if something changes to it, we don't consider it a breaking change. As a result, this change can be included in any hotfix, which means that any hotfix can now break our integration.
There was a problem hiding this comment.
it is there because of constant ReusableFieldSchemaConstants.SCHEMA_IDENTIFIER_KEY - if i hardcode it, then i loose chance to know that it was removed or changed - i need this, because manipulation with reusable field schemas.
If there is any public API that can get all fields out of reusable field schema i can drop this implementation and use it (and API that can determine which form field are from reusable field schema in one particular data class)
f9f70c5 to
a1612d2
Compare
* MT-28 XbyK upgrade 29.2.0 & obsolete configuration removed - breaking changes on MediatR resolved - obsolete project cleared - upgrade of solution dependencies * MT-28 legacy XbyK DB model regeneration + implied fixes * MT-17 migration of documents with non-unique DocumentGuid * MT-17 non-unique DocumentGUID & NodeGUID support * MT-17 cleanup * #184 deprecation of XbKConnectionString * #184 deprecation of XbKConnectionString - md file update * #198 migration of media file refactor; fails for member users resoved * confict resolving in relation to master branch * solution reformat to match master formatting * eol crlf * dotnet format autofix * merge conflicts fix * .editorconfig update & global reformat * reformat and code cleanup * dotnet format uncommented * Feat/199 unpublished doc versions published (#209) * document PublishTo & PublishFrom migration path support * whitespace corrections --------- Co-authored-by: Tomáš Krch <tomas@krch.tech> * naming conventions update, obsolete class removal * handling of multiple attachments with same guid in source instance - meaningful warning message --------- Co-authored-by: Tomáš Krch <tomas@krch.tech> Co-authored-by: fialafilip <99190657+fialafilip@users.noreply.github.com>
Motivation
Which issue does this fix? Fixes #199.