Add support for Kentico 13 #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…integrated security
… renamed property
|
@phixxo or @JohnL-Kentico, can you please test this PR using the instructions above? Code review isn't necessary, just test to ensure it is working |
This was
linked to
issues
Aug 8, 2023
Action matches Report service whitespace for easier comparison.
JosefDvorak
approved these changes
Nov 11, 2023
| @@ -15,6 +18,7 @@ namespace KenticoInspector.Reports.Tests | |||
| { | |||
| [TestFixture(10)] | |||
| [TestFixture(11)] | |||
| [TestFixture(11)] | |||
| @@ -64,14 +68,14 @@ public void Should_ReturnGoodStatus_WhenSiteIsInSubDirectoryAndRobotsTxtFound() | |||
| _mockReport = ConfigureReportAndHandlerWithHttpClientReturning(HttpStatusCode.OK, out Mock<HttpMessageHandler> mockHttpMessageHandler); | |||
| var mockInstance = _mockInstanceService.Object.CurrentInstance; | |||
|
|
|||
| var baseUrl = mockInstance.Url; | |||
| mockInstance.Url += "/subdirectory"; | |||
| var baseUrl = mockInstance.AdminUrl; | |||
There was a problem hiding this comment.
This is less than ideal, since it only covers PE sites
| } | ||
|
|
||
| public override IList<Version> CompatibleVersions => VersionHelper.GetVersionList("10", "11", "12"); | ||
| public override IList<Version> CompatibleVersions => VersionHelper.GetVersionList("10", "11", "12", "13"); |
There was a problem hiding this comment.
Does not properly handle Consent agreement Form component in Kentico 13, returning error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a large PR (sorry) that adds Kentico 13 support and also includes:
Checklist
How to test