Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update V4 branch with doc changes from master #251

Merged
merged 34 commits into from
Apr 29, 2019
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
528dfe1
Fixes #156 (#157)
ChristopherJennings Oct 17, 2017
f261af1
Fixes #158
ChristopherJennings Oct 17, 2017
6b8f826
Update README.md
petrsvihlik Nov 30, 2017
77f4d34
Fixes #160 (#162)
djjach Jan 9, 2018
7b359a2
Committing support version for Kentico-11 (#165)
sultanwork77 Feb 22, 2018
d449744
Fix #161 (#168)
djjach Mar 15, 2018
5b0b952
Fixes 167 (#169)
ChristopherJennings Apr 27, 2018
0b57cae
Added logic to check for empty string within the IN() query. (#175)
bkehren Jun 25, 2018
241b22c
TYPO - Resolve Typo "DON NOT RUN" (#176)
pstaylor-patrick Jul 13, 2018
8111384
Update README.md
Aug 28, 2018
bed095c
Add/update issue templates
Aug 30, 2018
e726fad
Add/update issue/PR templates
Sep 3, 2018
f256f1a
Add/update issue, PR templates, code of conduct, contributing guide
Sep 5, 2018
9dd564c
Merge pull request #177 from Kentico/dc-399-issue-templates
Sep 5, 2018
387ce2b
Replace http with https
Sep 6, 2018
bf46ae9
Add a check for CMSEnableCsrfProtection (#181)
amoraitis Oct 12, 2018
cbef3ce
Workflow XML parsed using ClassName instead of TableName and covers s…
yuriys-kentico Jan 17, 2019
ca04de5
Module refactoring #73 (#184)
JosefDvorak Jan 18, 2019
7ac4ded
Adds event log size and password format checks back in (#185)
ChristopherJennings Jan 18, 2019
d3aa998
Create CODEOWNERS
petrsvihlik Jan 26, 2019
ac35e86
Rename LICENSE.txt to LICENSE.md
petrsvihlik Jan 26, 2019
06574fc
Add/update issue, PR templates, code of conduct, contributing guide
petrsvihlik Jan 26, 2019
18de41f
Add/update issue, PR templates, code of conduct, contributing guide
petrsvihlik Jan 26, 2019
923c772
Page not founds module revisions (#192)
yuriys-kentico Feb 28, 2019
6f12d96
Attachments by size module revisions (#190)
yuriys-kentico Feb 28, 2019
626998c
Tree node children module revisions (#193)
yuriys-kentico Feb 28, 2019
eb1a1ae
Duplicate page aliases module revisions (#191)
yuriys-kentico Feb 28, 2019
412317f
Column/Field validation module (#194)
Feb 28, 2019
90a5f7a
Update README.md
Simply007 Mar 5, 2019
5f785ca
Recommended settings module (#189)
yuriys-kentico Apr 19, 2019
e02c466
Create migration_template.md
ChristopherJennings Apr 25, 2019
75048b4
Update migration_template.md
ChristopherJennings Apr 25, 2019
5e8e463
Merge branch 'master' into merge-master
ChristopherJennings Apr 29, 2019
84f7366
Updates package-lock after npm i
ChristopherJennings Apr 29, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes #158
  • Loading branch information
ChristopherJennings authored Oct 17, 2017
commit f261af1191f06a3ebf732ba4e6dfadc13cb08ef5
33 changes: 33 additions & 0 deletions KInspector.Modules/Modules/Content/WorkflowConsistencyModule.cs
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,39 @@ private List<string> CompareDictionaries(Dictionary<string, object> publishedVal
notMatchingFields.Add(publishedItem.Key);
}
}
else if (publishedItem.Value is decimal)
{
decimal publishedValue;
decimal.TryParse(publishedItem.Value.ToString(), out publishedValue);

decimal editedValue;
decimal.TryParse(editedValues[publishedItem.Key], out editedValue);

var valuesMatch = publishedValue == editedValue;

if (!valuesMatch)
{
var publishedPrecision = publishedValue.ToString().Split('.')?[1]?.Length;
var editedPrecision = editedValue.ToString().Split('.')?[1]?.Length;

if (publishedPrecision.HasValue && editedPrecision.HasValue)
{
var targetPrecision = publishedPrecision < editedPrecision ? publishedPrecision.Value : editedPrecision.Value;
var publishedTargetPrecision = Math.Round(publishedValue, targetPrecision, MidpointRounding.AwayFromZero);
var editedTargetPrecision = Math.Round(editedValue, targetPrecision, MidpointRounding.AwayFromZero);

if (publishedTargetPrecision == editedTargetPrecision)
{
valuesMatch = true;
}
}

if (!valuesMatch)
{
notMatchingFields.Add(publishedItem.Key);
}
}
}
else
{
// Check if the column has the same value as edited value
Expand Down