Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perform docker build as a pre-commit check #389

Closed
mik3y opened this issue Feb 25, 2020 · 1 comment
Closed

perform docker build as a pre-commit check #389

mik3y opened this issue Feb 25, 2020 · 1 comment

Comments

@mik3y
Copy link
Member

mik3y commented Feb 25, 2020

Right now the travis build only executes a "local python" build and test. Let's get some coverage for docker build into CI, too.

Seems like there may be a couple of options here:

  • Update the Travis build to be a docker build (instructions).
  • Add a new kind of build step (direct integration to docker hub or something).
  • Something else - plenty I don't know about.

thinking @hanzov69 may have some ideas based on our slack chat
@mik3y mik3y mentioned this issue Feb 25, 2020
Closed
mik3y added a commit that referenced this issue Mar 1, 2020
@mik3y
Add docker build Github Action
d29d02c 
Issue #389
@mik3y mik3y mentioned this issue Mar 1, 2020
Merged
@mik3y
Copy link
Member Author

mik3y commented Mar 8, 2020

done in #391 via github actions

@mik3y mik3y closed this as completed Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mik3y