Add must_not_match validator #365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Keats ping :) |
Keats
reviewed
Jan 23, 2025
validator_derive/src/lib.rs
Outdated
| @@ -178,6 +179,19 @@ impl ToTokens for ValidateField { | |||
| quote!() | |||
| }; | |||
|
|
|||
| // Must not match validation | |||
| let must_not_match = if let Some(must_not_match) = self.must_not_match.clone() { | |||
| // TODO: handle option for other | |||
There was a problem hiding this comment.
As I understood correctly - it was handled
Keats
reviewed
Jan 30, 2025
| /// Validates that the 2 given fields do not match. | ||
| /// Both fields are optionals | ||
| #[must_use] | ||
| pub fn validate_must_not_match<T: Eq>(a: T, b: T) -> bool { |
1dc4cb8 to
4d3607a
Compare
|
Looks like legit failures |
I fixed tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I want to add one more validator if you don't mind