Feat/entity attributes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnriqueSoria
reviewed
Mar 9, 2023
pyakeneo/result.py
Outdated
| self._items, | ||
| self._count, | ||
| ) = Result.parse_page(json.loads(r.text)) | ||
| if r.status_code == requests.codes.ok: |
There was a problem hiding this comment.
requests has a function for it
Suggested change
| if r.status_code == requests.codes.ok: | |
| if is_success(r.status_code): |
There was a problem hiding this comment.
I didn't find the method you suggest, instead I used the "ok" property
EnriqueSoria
reviewed
Mar 9, 2023
| @@ -74,23 +88,46 @@ def get_self_link(self): | |||
| def get_first_link(self): | |||
| return self._link_first | |||
|
|
|||
| @staticmethod | |||
| def parse_page(json_data): | |||
| @classmethod | |||
There was a problem hiding this comment.
Why this change if you don't use anything from cls?
There was a problem hiding this comment.
In case some day someone decides to inherit this class and customize that method
There was a problem hiding this comment.
You can override a staticmethod too, but nevermind
EnriqueSoria
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.