refactor: Rename callcode test files for clarity

Kava-Labs · Oct 16, 2024 · 0e39988 · 0e39988
1 parent 99c2f6e
commit 0e39988
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/tests/e2e-evm/contracts/ABI_CallerTest.sol → tests/e2e-evm/contracts/ABI_CallCodeTest.sol b/tests/e2e-evm/contracts/ABI_CallerTest.sol → tests/e2e-evm/contracts/ABI_CallCodeTest.sol
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.24;
 
-contract TargetContract {
+contract CallCodeTestContract {
     uint256 public storageValue;
 
     function getMsgInfo() external payable returns (address, uint256) {

diff --git a/tests/e2e-evm/test/callcode.test.ts b/tests/e2e-evm/test/callcode.test.ts
@@ -23,7 +23,7 @@ describe("CallCode", () => {
 
   interface CallCodeContext {
     lowLevelCaller: GetContractReturnType<ArtifactsMap["Caller"]["abi"]>;
-    implementationContract: GetContractReturnType<ArtifactsMap["TargetContract"]["abi"]>;
+    implementationContract: GetContractReturnType<ArtifactsMap["CallCodeTestContract"]["abi"]>;
   }
 
   interface callCodeTestCaseBase {
@@ -55,7 +55,7 @@ describe("CallCode", () => {
     let ctx: CallCodeContext;
 
     before("deploy called contract", async function () {
-      const contract = await hre.viem.deployContract("TargetContract");
+      const contract = await hre.viem.deployContract("CallCodeTestContract");
       ctx = {
         lowLevelCaller: lowLevelCaller,
         implementationContract: contract,
@@ -152,7 +152,7 @@ describe("CallCode", () => {
         }),
         // msg.sender is the caller contract
         wantSender: (ctx) => ctx.lowLevelCaller.address,
-        // msg.value is not preserved
+        // msg.value is not preserved via callcode
         wantValue: 0n,
       },
       {
@@ -174,6 +174,7 @@ describe("CallCode", () => {
             ],
           }),
         }),
+        // Storage in caller contract
         wantStorageContract: (ctx) => ctx.lowLevelCaller.address,
         wantStorageValue: 2n,
       },