Skip to content

ci: alert only on lints introduced in this branch (#2050) #2924

ci: alert only on lints introduced in this branch (#2050)

ci: alert only on lints introduced in this branch (#2050) #2924

Triggered via push November 4, 2024 20:19
Status Failure
Total duration 3m 50s
Artifacts

ci-commit.yml

on: push
lint  /  ...  /  Check Proto
3m 24s
lint / proto-lint / Check Proto
lint  /  golangci-lint
3m 42s
lint / golangci-lint
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 2 warnings
lint / golangci-lint: tests/util/evmsigner.go#L84
var-naming: func parameter evmChainId should be evmChainID (revive)
lint / golangci-lint: app/upgrades.go#L13
var-naming: don't use underscores in Go names; const UpgradeName_Mainnet should be UpgradeNameMainnet (revive)
lint / golangci-lint: app/upgrades.go#L14
var-naming: don't use underscores in Go names; const UpgradeName_Testnet should be UpgradeNameTestnet (revive)
lint / golangci-lint: tests/util/addresses.go#L20
Magic number: 128, in <argument> detected (mnd)
lint / golangci-lint: tests/util/evmsigner.go#L85
Magic number: 60, in <argument> detected (mnd)
lint / golangci-lint: tests/util/addresses.go#L24
error returned from external package is unwrapped: sig: func github.com/cosmos/go-bip39.NewMnemonic(entropy []byte) (string, error) (wrapcheck)
lint / golangci-lint: tests/util/evmsigner.go#L93
error returned from external package is unwrapped: sig: func github.com/ethereum/go-ethereum/crypto.HexToECDSA(hexkey string) (*crypto/ecdsa.PrivateKey, error) (wrapcheck)
lint / golangci-lint: app/upgrades.go#L60
error returned from external package is unwrapped: sig: func (github.com/cosmos/cosmos-sdk/types/module.Manager).RunMigrations(ctx github.com/cosmos/cosmos-sdk/types.Context, cfg github.com/cosmos/cosmos-sdk/types/module.Configurator, fromVM github.com/cosmos/cosmos-sdk/types/module.VersionMap) (github.com/cosmos/cosmos-sdk/types/module.VersionMap, error) (wrapcheck)
lint / golangci-lint
issues found
lint / proto-lint / Check Proto
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint / golangci-lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/