Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the requests library we can lose a lot of boilerplate code #9

Merged
merged 6 commits into from
Jan 29, 2016
Merged

Using the requests library we can lose a lot of boilerplate code #9

merged 6 commits into from
Jan 29, 2016

Conversation

mikaelgoldmann
Copy link
Contributor

No description provided.

@mikaelgoldmann
Copy link
Contributor Author

Actually, need a couple of try: except:

@mikaelgoldmann
Copy link
Contributor Author

Still some py3 problem. please wait.

austrin
austrin reviewed Jan 27, 2016
View reviewed changes
submit.py
@@ -339,22 +225,23 @@ def main():
seen.add(arg)

try:
opener = login_from_config(cfg)
cfg = get_config()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@austrin
Copy link
Contributor

austrin commented Jan 27, 2016

Looks great apart from the three minor comments.

As for adding an option to ignore cert errors/warnings, that would be nice but I can do that separately.

@mikaelgoldmann
PR fixes
94e56e0 
* print(foo, bar) rather than print(foo + bar)
* remove redundant line
* use dict literal
@mikaelgoldmann
More PR fixes to print function calls
179fb1a
austrin
austrin reviewed Jan 28, 2016
View reviewed changes
submit.py
else:
print(exc)
except requests.exceptions.RequestException as err:
print("Login connection failed:", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not single quotes

@mikaelgoldmann
Copy link
Contributor Author

I think I've taken care of the PR comments.

austrin added a commit that referenced this pull request Jan 29, 2016
@austrin
Merge pull request #9 from mikaelgoldmann/use-requests
aee7f78 
Using the requests library we can lose a lot of boilerplate code
@austrin austrin merged commit aee7f78 into Kattis:master Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaelgoldmann @austrin