Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor adjustments and additions to pass CRAN checks #1

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

blasee
Copy link

@blasee blasee commented Jan 3, 2018

Hi Kathy,

Here's a summary of the main changes:

  • Rename 'Data' directory to 'data'
  • Remove all files from 'vignettes' except for the Rmd
  • Use importFrom instead of import in roxygen comments so the NAMESPACE is less confusing
  • Minor adjustments in the DESCRIPTION (note - Authors@R and Depends fields)
  • Make sure all the examples work and the vignette can be compiled

Here's a few notes I made:

  • I would recommend updating from reshape to reshape2 (melt and cast functions)
  • Change Rd titles to title case
  • getLSDSummary returns all the same values in the example. Is this OK? (example(getLSDSummary))

@blasee
Copy link
Author

blasee commented Jan 22, 2018

OK the merge should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants