Apply OCP P3

NPC classes refactoring to enable player AI interactions extensions

SOLID/SOLID/Assets/Scripts/NPC.cs

@@ -0,0 +1,26 @@
+using UnityEngine;
+using UnityEngine.Events;
+
+public abstract class NPC : MonoBehaviour
+{
+    public UnityEvent<string> OnSpeak;
+
+    [SerializeField]
+    private AudioSource audioSource;
+
+    private void Awake()
+    {
+        audioSource = GetComponent<AudioSource>();
+    }
+
+    public virtual void Interact()
+    {
+        OnSpeak?.Invoke(GetText());
+        audioSource.Play();
+    }
+
+    protected virtual string GetText()
+    {
+        return string.Empty;
+    }
+}

SOLID/SOLID/Assets/Scripts/NPCEnemy.cs

@@ -1,16 +1,16 @@
-using UnityEngine;
-using UnityEngine.Events;
-
-public class NPCEnemy : MonoBehaviour
+public class NPCEnemy : NPC
 {
-    public UnityEvent<string> OnSpeak;
-    public AudioSource audioSource;
     public string text = "I deal 10 physical damage    ( •̀ᴗ•́ )و ̑̑ ";
 
-    public void GetHit()
+    public override void Interact()
     {
-        OnSpeak?.Invoke(text);
-        audioSource.Play();
+        base.Interact();
+
         FindObjectOfType<Player>().ReceiveDamaged();
     }
+
+    protected override string GetText()
+    {
+        return text;
+    }
 }

SOLID/SOLID/Assets/Scripts/NPCFriendly.cs

@@ -1,16 +1,9 @@
-using UnityEngine;
-using UnityEngine.Events;
-
-public class NPCFriendly : MonoBehaviour
+public class NPCFriendly : NPC
 {
-    public UnityEvent<string> OnSpeak;
-    public AudioSource audioSource;
     public string text = "Hi there. Look out for that KOBOLD on the other side!";
 
-    public void Talk()
+    protected override string GetText()
     {
-        OnSpeak?.Invoke(text);
-        audioSource.Play();
-
+        return text;
     }
 }

SOLID/SOLID/Assets/Scripts/PlayerAIInteractions.cs

@@ -11,13 +11,9 @@ public void Interact(bool isSpriteFlipped)
         RaycastHit2D hit = Physics2D.Raycast(raycastPoint.position, isSpriteFlipped ? Vector3.left : Vector3.right,1);
         if(hit.collider != null)
         {
-            if (hit.collider.GetComponent<NPCEnemy>())
+            if (hit.collider.TryGetComponent(out NPC npc))
             {
-                hit.collider.GetComponent<NPCEnemy>().GetHit();
-            }
-            else if (hit.collider.GetComponent<NPCFriendly>())
-            {
-                hit.collider.GetComponent<NPCFriendly>().Talk();
+                npc.Interact();
             }
         }
     }