Cherry-picked Optimized Rothschild performance on high TPS (kaspanet#371

)

consensus/core/src/tx.rs

@@ -275,20 +275,22 @@ impl Transaction {
         gas: u64,
         payload: Vec<u8>,
     ) -> Self {
-        let mut tx = Self {
-            version,
-            inputs,
-            outputs,
-            action,
-            lock_time,
-            subnetwork_id,
-            gas,
-            payload,
-            id: Default::default(), // Temp init before the finalize below
-        };
+        let mut tx = Self::new_non_finalized(version, inputs, outputs, action, lock_time, subnetwork_id, gas, payload);
         tx.finalize();
         tx
     }
+
+    pub fn new_non_finalized(
+        version: u16,
+        inputs: Vec<TransactionInput>,
+        outputs: Vec<TransactionOutput>,
+        lock_time: u64,
+        subnetwork_id: SubnetworkId,
+        gas: u64,
+        payload: Vec<u8>,
+    ) -> Self {
+        Self { version, inputs, outputs, lock_time, subnetwork_id, gas, payload, id: Default::default() }
+    }
 }
 
 impl Transaction {

rothschild/Cargo.toml

@@ -15,10 +15,20 @@ kash-rpc-core.workspace = true
 kash-addresses.workspace = true
 kash-txscript.workspace = true
 kash-utils.workspace = true
+async-channel.workspace = true
+parking_lot.workspace = true
 
 clap.workspace = true
 faster-hex.workspace = true
 itertools.workspace = true
 log.workspace = true
+rayon.workspace = true
 secp256k1 = { workspace = true, features = ["global-context", "rand-std"] }
 tokio = { workspace = true, features = ["rt", "macros", "rt-multi-thread"] }
+
+[dev-dependencies]
+criterion.workspace = true
+
+[[bench]]
+name = "bench"
+harness = false

rothschild/benches/bench.rs

@@ -0,0 +1,47 @@
+use criterion::{criterion_group, criterion_main, Criterion};
+use rayon::prelude::*;
+
+use kash_consensus_core::{
+    constants::TX_VERSION,
+    subnets::SUBNETWORK_ID_NATIVE,
+    tx::{ScriptPublicKey, Transaction, TransactionInput, TransactionOutpoint, TransactionOutput},
+    Hash,
+};
+
+fn constuct_tx() -> Transaction {
+    let inputs = vec![TransactionInput {
+        previous_outpoint: TransactionOutpoint { transaction_id: Hash::from_bytes([0xFF; 32]), index: 0 },
+        signature_script: vec![],
+        sequence: 0,
+        sig_op_count: 1,
+    }];
+    let outputs = vec![TransactionOutput { value: 10000, script_public_key: ScriptPublicKey::from_vec(0, vec![0xff; 35]) }];
+    Transaction::new(TX_VERSION, inputs, outputs, 0, SUBNETWORK_ID_NATIVE, 0, vec![])
+}
+
+fn construct_txs_serially() {
+    let _ = (0..10000)
+        .map(|_| {
+            constuct_tx();
+        })
+        .collect::<Vec<_>>();
+}
+
+fn construct_txs_parallel() {
+    let _ = (0..10000)
+        .into_par_iter()
+        .map(|_| {
+            constuct_tx();
+        })
+        .collect::<Vec<_>>();
+}
+
+pub fn bench_compare_tx_generation(c: &mut Criterion) {
+    let mut group = c.benchmark_group("compare txs");
+    group.bench_function("Transaction::SerialCreation", |b| b.iter(construct_txs_serially));
+    group.bench_function("Transaction::ParallelCreation", |b| b.iter(construct_txs_parallel));
+    group.finish();
+}
+
+criterion_group!(benches, bench_compare_tx_generation);
+criterion_main!(benches);