Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --selectedTables switch #12

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Conversation

acaloiaro
Copy link
Contributor

ERD generation in CI/CD is a pretty common workflow, and some projects understandably will not want to introduce a memerd configuration file to their projects simply to specify which tables to include in the diagram.

This simple modification exposes the --selectedTables switch, so it's not necessary to create a configuration file to select tables for diagram inclusion.

@acaloiaro
Copy link
Contributor Author

@KarnerTh Since there is no CONTRIBUTING.md, I wasn't sure what your process is for proposing changes, so I simply opened this PR up for you to critique. If you do wish to include this, I'm happy to do the extra work of making sure that the changes are included in the requisite documentation.

Cheers

@KarnerTh
Copy link
Owner

@acaloiaro thanks for the PR - the changes look good to me!
Please add the flag also to the readme section "Parameter and flags" (https://github.com/KarnerTh/mermerd#parametersflags) - after that I will happily merge back your changes

And thanks for pointing out the missing contribution docs, I will add them in the near future 👍

@KarnerTh
Copy link
Owner

KarnerTh commented Aug 1, 2022

In order to make the flag available in the next release, I will merge back that PR as it is and add the documentation afterwards

@KarnerTh KarnerTh merged commit b3b79a9 into KarnerTh:master Aug 1, 2022
@acaloiaro
Copy link
Contributor Author

Hey @KarnerTh -- sorry about being negligent here. I forgot to follow up on those docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants