Allow-list netty experimental VM options lines #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are out of our control and quarkus would need a netty update to deal with this.
zakkak
approved these changes
Sep 19, 2023
jsmrcka
added a commit
to jsmrcka/quarkus-startstop
that referenced
this pull request
Nov 1, 2023
`-H:ReflectionConfigurationResources` - Reported in `netty`: netty/netty#13595. - Fixed in `netty`: netty/netty#13596. - See also similar issue in Karm/mandrel-integration-tests#190 and its workaround in Karm/mandrel-integration-tests#203. `-H:Log=registerResource` - Added explicitly by `APP_FULL_MICROPROFILE` config. - Use case documented in Quarkus Native Reference Guide, documentation added in quarkusio/quarkus#36494.
jsmrcka
added a commit
to jsmrcka/quarkus-startstop
that referenced
this pull request
Nov 2, 2023
`-H:ReflectionConfigurationResources` - Reported in `netty`: netty/netty#13595. - Fixed in `netty`: netty/netty#13596. - See also similar issue in Karm/mandrel-integration-tests#190 and its workaround in Karm/mandrel-integration-tests#203. `-H:Log=registerResource, -H:Log=registerResource:` - Added explicitly by `APP_FULL_MICROPROFILE` config. - Typical use case documented in Quarkus Native Reference Guide, the documentation was added in quarkusio/quarkus#36494. - Allow-listed, instead of using `-H:+UnlockExperimentalVMOptions` / `-H:-UnlockExperimentalVMOptions`, to avoid errors with GraalVM / Mandrel based on Java < 21, which do not recognize this option (see oracle/graal#7105).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are out of our control and quarkus would need a netty update to deal with this.
Closes #190 and #201. Final piece of #188.