-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PolkaGate Extension #158
Conversation
✅ Deploy Preview for dreamy-gates-ad44c0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @AMIRKHANEF! Thanks for submitting this PR, that's very thoughtful!
Ps.: I don't know if you are aware, but your bid of 0 KSM is still up and it's going to be accepted in 3 days and 12 hours, which means you'll become a candidate eligible to get a tattoo. I'm not sure if that's your intention, letting you know just in case 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, CI seems to be breaking because we are using an older version of Yarn.
I'll be OOO this next week, but I'll try to update Yarn in the next few weeks.
Hi @laurogripa, Thanks for reviewing this PR! Enjoy your time out of the office, and next week works perfectly. Regarding the tattoo, my apologies—I didn't realize such a small bid would actually go through. Thanks for the heads-up! I'll make sure to withdraw the bid before it gets accepted, as that wasn’t my intention. |
As you can see, I upgraded the "@talismn/connect-wallets" to 1.2.5, which requires a newer version of Yarn. To address this, I went ahead and updated Yarn as well. |
@AMIRKHANEF Yeah, I just had to update Yarn on CI too. Now it's working! But I'm getting a weird behavior: I don't have any accounts imported on my PolkaGate extensions, but the selector lists my Talisman account as a possible choice for PolkaGate. It also happens if I connect an account from Polkadot.js. Same issue. Apparently, the account selector lists the accounts from the last selected wallet instead of PolkaGate. Can you take a look at this issue? You can use chopsticks if you need to test any signed extrinsic, the instructions are in the README file. If not, I'll take a look later this week. |
Hey @laurogripa, thanks for pointing this out! The issue you encountered happens because PolkaGate handles account selection differently compared to other wallets when no account is selected for interacting with a DApp. Thanks again for your help! |
@AMIRKHANEF Ok, great! I'll leave this open until the next release, so we can update the version and ship it! |
a280dc3
to
497d6b2
Compare
Hey @laurogripa, just wanted to give you a quick update! The issue has been addressed in the latest release Feel free to try it out, and let me know if everything works smoothly on your end! Thanks again for your patience! |
@AMIRKHANEF All good now, working great! Thanks again for your contribution! ❤️ |
Description
This pull request aims to add the PolkaGate extension to the Kappa Sigma Mu membership club website as a login option.
Changes Proposed
Motivation and Benefits
Improved User Experience: The addition of the PolkaGate extension will offer users an alternative and secure login method.
Enhanced Accessibility: It will make it easier for users of the Polkagate extension to engage with the Kappa Sigma Mu membership club website.
Screenshots