Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix deleted files #20

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Bugfix deleted files #20

merged 1 commit into from
Dec 10, 2022

Conversation

KanHarI
Copy link
Owner

@KanHarI KanHarI commented Dec 10, 2022

No description provided.

@KanHarI KanHarI merged commit c9560aa into master Dec 10, 2022
@KanHarI KanHarI deleted the bugfix/deletions branch December 10, 2022 21:36
github-actions[bot]
github-actions bot reviewed Dec 10, 2022
View reviewed changes
lib/index.js
@@ -19014,7 +19014,9 @@ function getFilesSummaries(pullNumber, repository) {
commit_id: headCommitSha,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT summary of 009cc5 - f9afda:

  • Line 19014 was modified to check if the modifiedFiles[modifiedFile].position value is greater than 0, and if so, use that value, otherwise use 1.

github-actions[bot]
github-actions bot reviewed Dec 10, 2022
View reviewed changes
src/filesSummary.ts
@@ -193,7 +193,9 @@ export async function getFilesSummaries(
commit_id: headCommitSha,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT summary of 943050 - da4bae:

  • Modified the condition for the line parameter in the getFilesSummaries function to ensure that the line number is always greater than 0.

@github-actions
Copy link

GPT summary of 4056cfa:

  • Adjusted the line number for the filesSummary.ts and index.js files to be 1 if the position is 0 or lower index.js, filesSummary.ts

PR summary so far:

  • Adjusted the line number for the filesSummary.ts and index.js files to ensure that the line number is always greater than 0.
  • Improved the condition for the line parameter in the getFilesSummaries function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KanHarI