-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(lerna config): update release-deploy config to correct version numbering #727
Conversation
…ber increment closes #726
@monkeypox8 I think you need to add an additional - name: Clone Sage-Lib Repo
uses: actions/checkout@v2
with:
# Pulls all commits (needed for Lerna / Semantic release to correctly version)
fetch-depth: "0"
run:
# Pulls all tags (needed for Lerna / Semantic release to correctly version)
git fetch --depth=1 origin +refs/tags/*:refs/tags/* |
Whoa, great catch. I missed that piece entirely and will update. Thanks! |
@voodooGQ I was reading through the originating issue comments and saw that there's potential for merge errors when adding that last line. Thinking now we give this update a try first, and if it doesn't take we add the tags as well, but happy to amend if you think it's safe to do so. |
@monkeypox8 Yeah I didn't notice that piece. I'd say your approach makes sense, let's roll with it :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
🛑 ON HOLD until sage version bump has mergedFollowing a Sage version bump, the generated tag and package release version for Sage does not increment as expected:
Expected:
v4.11.5
->v4.12.0
Actual:
v4.11.5
->v4.11.6
This happens regardless of the size and scope of the changeset due to a bug with Lerna in Github Actions that @voodooGQ uncovered: lerna/lerna#2542
This PR adds a new setting in our build process which forces Lerna to inspect all commits. The tagging addition mentioned in the issue thread has been left off for this first pass at a fix.
main
;develop
should be rebased afterwards.Screenshots
No visual changes
Testing in
sage-lib
Local testing is not possible. We'll need to generate a new release/package to verify the versioning has been corrected.
Testing in
kajabi-products
N/A. This branch will not affect existing components
Related