update CsvHelper to 29.0.0 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## ValidationService project - migrate ValidationService project to netstandard2.0 - replace log4net with Microsoft.Extensions.Logging (when needed) - replace LoggingService validation logging mechanism with ValidationOutput property to programmatically fetch the validation output - remove LoggingService global logging mechanism because it was not more usable (and already throwing exceptions) - remove ValidationResultCollection mechanism as it duplicates most validation errors - mark LoggingService as obsolete - upgrade/migrate CSVHelper from version 12.1.1 to 27.1.1 ## ValidationTests project - migrate ValidationTests project to net5.0 - upgrade/migrate CSVHelper from version 12.1.1 to 27.1.1 - fix test issues with CSVHelper & PackageValidator - rewrote FullValidationTests to pass with all packages located in the DataSource folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.