Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shape arg #43

Merged
merged 6 commits into from
Sep 21, 2022
Merged

Add shape arg #43

merged 6 commits into from
Sep 21, 2022

Conversation

hsonne
Copy link
Member

@hsonne hsonne commented Sep 20, 2022 •
edited by mrustl
Loading

This change is Reviewable

@hsonne
Extract transform_coords(), add arg "use_sf"
4404369
@hsonne
Allow to pass spatial object or no shape at all
67a83b7 
You may now read a shape file on your own,
and pass the corresponding spatial object
(or e.g. a subset of it) to the funcion
read_monthly_data_over_shape(). You may also
set both, "file" and "shape" to NULL and should
receive data for the whole area of Germany.
@hsonne
Update Rd file
350efa4
@hsonne
Use raster::getValues() instead of @DaTa@values
183cbfe 
r@data@values is logical(0) for the whole of
Germany, however getValues() returns the values
@hsonne
Extend example script, download rain Bezirke Bln
c3653b9
@hsonne hsonne requested a review from mrustl September 20, 2022 17:30
@mrustl
Copy link
Member

mrustl commented Sep 20, 2022

Works for me....maybe have a look at #44

@mrustl mrustl merged commit 564eace into dev Sep 21, 2022
@mrustl mrustl deleted the add-shape-arg branch September 21, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrustl mrustl Awaiting requested review from mrustl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsonne @mrustl