Remove redundant checks from RefuelingPump

KSP-RO · Oct 11, 2024 · 4a3dcf1 · 4a3dcf1
1 parent 1982f54
commit 4a3dcf1
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/Source/Pumps/RefuelingPump.cs b/Source/Pumps/RefuelingPump.cs
@@ -104,13 +104,10 @@ private void FillAttachedTanks(double deltaTime)
 
             foreach (var tank in tankDefs)
             {
-                if (tank.maxAmount > 0 &&
-                    tank.resource is PartResource r &&
+                if (tank.resource is PartResource r &&
                     PartResourceLibrary.Instance.GetDefinition(r.resourceName) is PartResourceDefinition d &&
                     tank.amount < tank.maxAmount &&
-                    tank.fillable &&
-                    r.flowMode != PartResource.FlowMode.None && r.flowState &&
-                    d.resourceTransferMode == ResourceTransferMode.PUMP)
+                    r.flowMode != PartResource.FlowMode.None && r.flowState)
                 {
                     double amount = Math.Min(deltaTime * pump_rate * tank.utilization, tank.maxAmount - tank.amount);
 
@@ -127,6 +124,7 @@ tank.resource is PartResource r &&
                     tank.part.TransferResource(r, amount, part);
                 }
             }
+
             foreach (var partResource in batteries)
             {
                 if (partResource.flowMode != PartResource.FlowMode.None &&