Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As we advance toward the finish line of KSP2 support, we are getting closer to the point where we will need to be able to validate, review, and merge
KSP2-NetKAN
pull requests. This will require updatingxKAN-meta_testing
to support the new game.Problem
Only KSP1 support exists for:
Changes
Now the Action has a
game
parameter, defaulting toKSP
, which allows the configuration file to specify how to get game versions and the value of the--game
parameter fornetkan.exe
andckan instance fake
commands. This is done by creating a newGame
abstract base class with derived classesKsp1
andKsp2
, which provide public properties specifying their short names and their known game versions. Code that needs these values is updated to get them fromGame
objects that are now deduced from theGAME
environment variable and then passed around.In the process of making these changes, the validator is now switched from retrieving the embedded build map, which has been renamed to
builds-ksp.json
in KSP-CKAN/CKAN#3797, to using the remote build maps, which are not subject to naming collisions because they're in separate repos.--game
parameter to be available everywhere it's needed!