Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CST100Starliner install #7945

Merged
merged 1 commit into from
May 30, 2020
Merged

Fix CST100Starliner install #7945

merged 1 commit into from
May 30, 2020

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented May 30, 2020

Problem

image

Cause

The ZIP contains a Ships folder with one craft file in it, with no VAB or SPH subfolder.

Metadata:

        "find":       "Ships",
        "install_to": "Ships",
        "as":         "VAB"
Mod version Ships folder path in ZIP
2.0 /CST-100 Starliner/Ships/
2.1 /Ships/

The as property isn't allowed if the install stanza is trying to install just Ships in the root of the ZIP. The reason for this is a bit fishy but also somewhat complex to sort out.

Changes

We could monkey with the C# code (and still may), but that won't help users trying to install this with the current client. So now we match the file instead of the folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant