Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little Green Men From Mars: New maintainer and dependencies #2950

Merged
merged 3 commits into from
Feb 4, 2016
Merged

Little Green Men From Mars: New maintainer and dependencies #2950

merged 3 commits into from
Feb 4, 2016

Conversation

TiktaalikDreaming
Copy link
Contributor

Developer is unfamiliar with CKAN, but clearly someone created this very nice complete file for the prerelease LGMFM. KerbalStuff bot is likely to try creating the netkan file again, but I suspect it'll fail due to having the same name etc.

Developer is unfamiliar with CKAN, but clearly someone created this very nice complete file for the prerelease LGMFM.  KerbalStuff bot is likely to try creating the netkan file again, but I suspect it'll fail due to having the same name etc.
@pjf
Copy link
Member

pjf commented Jan 29, 2016

Aww yis, I love this mod. :)

From https://kerbalstuff.com/mod/1412 it looks like it needs RSS-Textures as well, which may try to load in all of RSS. Checking now.

@pjf
Copy link
Member

pjf commented Jan 29, 2016

Yup, the RSS textures will try to load all of RSS.

@NathanKell : Do you see any problems if we make the RSS textures "recommend" RSS, rather than depend upon it? We'll still have RSS depend upon the textures, so we're only weakening the relationship in one direction.

@TiktaalikDreaming : Thank you so much for the metadata changes thus far! We almost certainly want to add a "depends" : "RSSTextures" line, and a "conflicts" : "RealSolarSystem" line. This will make sure users get the textures, but don't also install RSS by accident. (You can add that as an additional commit if you like, or we can make the changes as part of the merge process.)

@pjf pjf changed the title Release version is different mod num Little Green Men From Mars: New maintainer and dependencies Jan 29, 2016
@TiktaalikDreaming
Copy link
Contributor Author

I can quickly whack in the depends and conflicts. If I'd thought about the actual install process, I could have shortcut this by doing this to start with. :-/

@NathanKell
Copy link
Contributor

I have no objection. Apologies for the delay.

That said, I'll take this opportunity to mention that, despite the RO netkan (and the RP-0 netkan) recommending RSS, it is (per user reports) often not installed as it should be. Halp?

@TiktaalikDreaming
Copy link
Contributor Author

@NathanKell it's be pretty hard to eliminate user-error for a "recommends":. I'll let someone in the know answer though. Hell, I'm still struggling with the github interface. :-)

@NathanKell
Copy link
Contributor

Recommends, by definition, means the recommended mod should be auto-selected. That appears to not be the case.

@politas
Copy link
Member

politas commented Jan 31, 2016

Well, I can see the recommend for RealSolarSystem in the .ckan file and my registry.json, but indeed, it does not get listed in the "Recommends" list after clicking "Apply" to the changeset.

@mheguy
Copy link
Contributor

mheguy commented Feb 4, 2016

Looks all set. Merging with my thanks.

mheguy pushed a commit that referenced this pull request Feb 4, 2016
Little Green Men From Mars: New maintainer and dependencies
@mheguy mheguy merged commit c481b53 into KSP-CKAN:master Feb 4, 2016
@mheguy
Copy link
Contributor

mheguy commented Feb 4, 2016

@NathanKell For what it's worth the issue you're bringing up has been around for a while (KSP-CKAN/CKAN#1346). A workaround is to install RSS seperately or use the CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants