Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to clear auto-installed flag from changeset tab #4033

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Feb 15, 2024

Motivation

The Changeset tab is shown when you choose to install, upgrade, or uninstall mods and then click Apply. If there is something in the list that you don't want, the only way to fix it is to click Back, then scroll or search through the mod list to find the affected mods, then make whatever change would undo the change, then click Apply again. This is cumbersome, especially for auto-installed mods, since the user may not know the full details of how to mark them as not auto-installed.

Changes

  • Now the Changeset tab list has a "Skip?" column at the right
  • Changes that would be simple to remove from the changeset (independent from other changes) have an "X" icon in this column with a tooltip like "Don't Install MyMod 1.0.0"
  • Changes that are not simple to remove (other changes depend on them) have no such icon
  • If you click an X icon, a confirmation popup asks you if you really want to remove that change from the changeset
  • If you cancel in the popup, the change stays in the changeset
  • If you confirm the removal, the change is removed and the changeset is recalculated
  • A bug is fixed where clicking the Clear button would mark many auto-installed modules as not auto-installed

Thanks to @JonnyOThan for providing in-depth UI feedback and saving us from ambiguous checkboxes.

image

image

Fixes #4012.

@HebaruSan HebaruSan added Enhancement New features or functionality GUI Issues affecting the interactive GUI labels Feb 15, 2024
@HebaruSan HebaruSan force-pushed the feature/changeset-checkboxes branch from e939d85 to f5153cb Compare February 15, 2024 20:48
@HebaruSan HebaruSan added the In progress We're still working on this label Feb 15, 2024
@HebaruSan HebaruSan force-pushed the feature/changeset-checkboxes branch from f5153cb to a2e2b20 Compare February 15, 2024 22:46
@HebaruSan HebaruSan removed the In progress We're still working on this label Feb 15, 2024
@HebaruSan HebaruSan merged commit 68b9233 into KSP-CKAN:master Feb 15, 2024
8 checks passed
@HebaruSan HebaruSan deleted the feature/changeset-checkboxes branch February 15, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New features or functionality GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changeset screen should have a way to keep auto-installed mods
1 participant