Fix Netkan check for Ships/Script spec_version #3713
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
kOS scripts are installed to
Ships/Script
. We added support for this in #3180, including a Netkan validation check that thespec_version
wasv1.29
or later, since earlier versions of CKAN wouldn't support it.Problem
The check only triggers for one specific case:
There are other ways to install into that path:
Remembered while reviewing KSP-CKAN/NetKAN#9443, which almost slipped by with a bad
spec_version
because of it.Changes
Now the Netkan validation checks for these other cases. It may still miss some things, but it's better than no check at all.