Fix modpack installation, install incompatible with confirmation #3675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
installed-
prefixAdditional motivation
I felt like assembling my own modpack that I'm calling "Stock Plus," focused on enhancing the gameplay of the stock solar system and parts; if anyone is interested, I may be publishing it once this PR's changes are released. Working on this with the current dev build was how I discovered that modpack installation is broken.
A few mods that I really wanted are not marked compatible with KSP 1.10–1.12 (but they do work), which means I can still install them via the Versions tab by overriding a proper compatibility warning, but the options for adding them to a metapackage .ckan file are not satisfactory:
Either way, the incompatible mods that I want in my pack can't be installed via a modpack. I think we've had other modpack creators ask about this before, so it's potentially of general interest.
Changes
CkanModule.HighestCompatibleKSP
, and hence also changed capitalization to "KSP All versions" in EnglishThis will make modpack installation more closely replicate the user experience of installing the same set of mods without a modpack.
string.Format
index, despite occurring earlier in the main string. For consistency, this same ordering is also used for the above warning.ksp_version_min
andksp_version_max
are set based on your current compatibility settingsLicense.UnknownLicense
instead of hard coded in the registry managerdownload_content_type
is set based on theDefaultValue
attribute instead of hard coded in the registry managerdepends
,recommends
, andsuggests
properties will now be omitted instead of[]
if they are empty