-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill more info from GitHub for SpaceDock mods #3390
Conversation
I know of one mod, InterstellarFuelSwitch, which appends a path to the repo link on purpose, since the repo is shared with KSPIE:
It would be neat to keep this, though cleaning "dirty" links with suffixes that don't make sense, like |
I think this is the complete list of long repositories, but not necessarily limited to those hosted on SpaceDock, shared for background purposes:
|
OK, I looked at the list, and this seemed like the only example of a meritorious use of this behavior, so I moved it to the .netkan so it won't be overwritten by the true repo link if this PR is merged. |
Hm, what about these?
They also look like they match this scheme. |
Good point, added those to the netkans as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We just need to remember to check the exact repo link on SpaceDock for new netkans and hardcode it if it points to a valid, sensible subdirectory.
Motivation
#3384 added the ability to set
resources.bugtracker
for SpaceDock mods with a source code link to a GitHub repo with the issues list enabled. This is nice, but there is more we can do.Changes
Now if a SpaceDock mod has a source code link that points to GitHub, we do a little more with the GitHub API info:
resources.repository
will be set to the proper URL of the repo, so the CKAN metadata will be current in case it has been moved or renamed (I think this will also remove suffixes like/releases
from repo links that have them, which is probably good)resources.homepage
(this will probably be very rare, people usually set the homepage on SpaceDock and rarely set it on GitHub)The code is restructured slightly to allow for this, since
getBugtracker
is not a great place to put the new code.