Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dialog was too small for French localization #3313

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Update dialog was too small for French localization #3313

merged 1 commit into from
Mar 6, 2021

Conversation

vinix38
Copy link
Contributor

@vinix38 vinix38 commented Mar 6, 2021

Since this dialog only shows up on updating, I had no way to check if it worked.
When updating to 1.30, I noticed that the "not now" button wasn't big enough.
I made it bigger, and I shortened the text, but I don't know how to test my changes.

@HebaruSan HebaruSan added Bug Something is not working as intended GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating Pull request AutoUpdate Issues affecting the automatic updating labels Mar 6, 2021
@HebaruSan

This comment has been minimized.

@HebaruSan
Copy link
Member

Just for completeness I turned on all the startup prompts that I could find:

image

image

image

I'll see if we can turn on word wrap for that first one...

@HebaruSan
Copy link
Member

HebaruSan commented Mar 6, 2021

With just a little finagling (commit incoming shortly):

image

Slightly better:

image

@HebaruSan
Copy link
Member

Also updated the names of the controls because button1 is a poor counterpart to YesButton.

@HebaruSan
Copy link
Member

I made it bigger, and I shortened the text, but I don't know how to test my changes.

@vinix38, from that description it sounds like you meant to widen this button:

//
// CancelUpdateButton
//
this.CancelUpdateButton.Anchor = ((System.Windows.Forms.AnchorStyles)((System.Windows.Forms.AnchorStyles.Bottom | System.Windows.Forms.AnchorStyles.Right)));
this.CancelUpdateButton.DialogResult = System.Windows.Forms.DialogResult.Cancel;
this.CancelUpdateButton.FlatStyle = System.Windows.Forms.FlatStyle.Flat;
this.CancelUpdateButton.Location = new System.Drawing.Point(258, 277);
this.CancelUpdateButton.Name = "CancelUpdateButton";
this.CancelUpdateButton.Size = new System.Drawing.Size(75, 23);

Would you still want to do that?

@vinix38
Copy link
Contributor Author

vinix38 commented Mar 6, 2021

from that description it sounds like you meant to widen this button:

You are right,, I modified the wrong dialog layout (oupsi...)

image
I did not mean to modify this one, the previous size was probably alright, you can revert my changes I think

image
This was the one I aimed to fix. The new translation of "not now" seems to be enough, no need to change the button size then

@HebaruSan
Copy link
Member

OK, I'll revert the wide "Non" button, but I do think the other buttons could stand to be wider (and the same visual style as the ones on the other popups). Incoming with next commit:

image

image

Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@HebaruSan HebaruSan merged commit 6ec7270 into KSP-CKAN:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoUpdate Issues affecting the automatic updating Bug Something is not working as intended GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants