Handle incompatible force-installed dependencies of recommendations #3305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
(One example is RasterPropMonitor and RasterPropMonitor-Core, which are not compatible with KSP 1.11, and recommend ASETProps, which depends on RasterPropMonitor-Core.)
(In our example, this is ASETProps)
On Linux, the same exception is printed to stdout.
Cause
The conflict checker in the recommendations/suggestions screen doesn't know about the mods we're force-installing, so when it asks the
RelationshipResolver
to look for conflicts, it finds out that the dependencies aren't satisfied.Changes
LoadRecommendations
has parameters for the mods that are planned to install and remove, and it includes them in the mods it passes to theRelationshipResolver
for checking conflictsFixes #3303.