Add test for Control.Language property resource #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
cbdb20f to
2d3d8c6
Compare
DasSkelett
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#3218 fixed a problem with Mono 6 generating builds that don't work on Windows, but there's a risk that Visual Studio will create the problem again by setting the
$this.Languageproperty of a.resxfile. If this happens, the current maintainers may not remember or may never have known that this is a problem, and a broken release could happen.Changes
Now a new Test checks that
$this.Languageis not set in any known resource file, which will prevent this problem from recurring in the future. To achieve this,SingleAssemblyComponentResourceManageris marked asinternaland the Tests project is given internals-visibility into the GUI project.