Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage repos with separate name and URL fields #3214

Merged
merged 2 commits into from
Nov 28, 2020

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Nov 27, 2020

Problems

The repo and auth token sections of the GUI Settings use pipe characters to fake multiple columns:

image

The popup to add a repo:

image

  • has title "Settings"
  • is enormous compared to how much space its content requires
  • isn't resizable
  • also uses pipe characters to fake multiple columns in the list
  • requires the user to type pipe characters in a special format to enter a custom repo
  • has no label for its text field
  • has the text field, cancel, and OK buttons inside the "Official repositories" frame even though these controls are not related to official repositories

Changes

image

  • The repo table in Settings is a ListView with two columns
  • The auth token table in Settings is a ListView with two columns

image

  • Title is now "Add Repository"
  • The blank space in the repo list is reduced
  • The form is resiable
  • The list is now a ListView with two columns
  • The text box is split into one for name, one for URL, each with a label, so the user doesn't have to type pipes
  • The text box and buttons are moved outside the "Official repositories" frame
  • The "OK" button is now relabeled to the more descriptive "Add" and is the same width as the other button, and they have keyboard shortcuts

@HebaruSan HebaruSan added Enhancement New features or functionality GUI Issues affecting the interactive GUI Pull request labels Nov 27, 2020
@HebaruSan HebaruSan requested a review from DasSkelett November 27, 2020 20:08
@DasSkelett
Copy link
Member

I've just pushed a small fix for the auth token section, we used to disable the DeleteRepoButton instead of the DeleteAuthTokenButton there.

Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved usability 🎉

@HebaruSan HebaruSan merged commit d54a7fa into KSP-CKAN:master Nov 28, 2020
@HebaruSan HebaruSan deleted the fix/repos-without-pipes branch November 28, 2020 18:10
@DasSkelett DasSkelett added the i18n Issues regarding the internationalization of CKAN and PRs that need translating label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New features or functionality GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants