Escape '&' in mod list, consistent path separators in exception #3149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Ampersands (
&
) in mod names or abstracts in the mod list are currently interpreted as hint to create automatic keyboard shortcuts (visualized through underscores), instead of printing them as literal.See for example the mod
DumpAndBurn
, with the nameDump&Burn!
:Error messages of krakens thrown while trying to load the
GUIConfig.xml
have a mix of/
and\
as path seperators on Windows, like:Changes
The texts in the name, author and abstract are now escaped using
&&
inModList.MakeRow()
. I didn't spot another location where they would need escaping (tested recommendation tab and modpack export tab).The exception about broken
GUIConfig.xml
files now gets the path string from aFileInfo
object, which should always be formatted consistently and correctly for the user's OS.