Fix missing DLC registration gap #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DasSkelett
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Up until a few minutes ago, the v1.28.0 client thought nobody on KSP 1.10.x had any DLCs installed.
KSP-CKAN/CKAN-meta#2130 added the new DLC metadata to fix this, but in the meantime the client should have fallen back on mocked-up CkanModules to represent the DLC.
Cause
The fallback code only runs in case the DLC identifier isn't found. If the identifier exists but the DLC version found on disk isn't available (99.99% of real world usages), then
RegisterDlcdoes nothing.Changes
Now
RegisterDlcalways adds something to the installed modules list. First it looks for the identifier and version in the available modules list, and if either isn't found, then it makes the fake module, as intended.Fixes #3135.