Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more specific in GUI config parse error #3090

Merged
merged 3 commits into from
Jun 28, 2020

Conversation

HebaruSan
Copy link
Member

Problem

Apparently this message is confusing:

image

image

Changes

Now 'it' is replaced with the file name and 'the folder' is replaced with the folder path. Hopefully this gives folks a clearer idea of what to do. I think I got the change right for German, but maybe a "zum" needs to become a "zur" or something.

CKAN.Kraken: Error trying to parse "/home/user/.local/share/Steam/steamapps/common/Kerbal Space Program/CKAN/GUIConfig.xml": Data at the root level is invalid. Line 2, position 1.. Try to move GUIConfig.xml out of /home/user/.local/share/Steam/steamapps/common/Kerbal Space Program/CKAN and restart CKAN.

@HebaruSan HebaruSan added Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request labels Jun 28, 2020
@HebaruSan HebaruSan requested a review from DasSkelett June 28, 2020 17:21
@DasSkelett
Copy link
Member

Data at the root level is invalid. Line 2, position 1..

Wonder if it makes sense to remove the duplicate period, or if that will result in other error messages having none :D

@HebaruSan
Copy link
Member Author

HebaruSan commented Jun 28, 2020

How about a line break?

$ _build/ckan.exe
1294 [1] ERROR CKAN.ErrorDialog (null) - Unhandled exception:
CKAN.Kraken: Error trying to parse "/home/paul/.local/share/Steam/steamapps/common/Kerbal Space Program/CKAN/GUIConfig.xml": Data at the root level is invalid. Line 2, position 1.
Try to move GUIConfig.xml out of /home/paul/.local/share/Steam/steamapps/common/Kerbal Space Program/CKAN and restart CKAN.

Not sure how that would translate to Deutsch though.

@DasSkelett
Copy link
Member

Not sure how that would translate to Deutsch though.

This will work, since I plan to change the structure of German message to match the English one. 👍

Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope that was not the only user that actually reads error messages.

@HebaruSan HebaruSan merged commit 03b4cff into KSP-CKAN:master Jun 28, 2020
@HebaruSan HebaruSan deleted the fix/config-parse-err branch June 28, 2020 20:34
@DasSkelett DasSkelett added the i18n Issues regarding the internationalization of CKAN and PRs that need translating label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants