Move WebException stack trace from User error to verbose log #3062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Download errors look like this currently:
This is scary-looking and redundant; the
WebException
stack trace does not contain useful information, and we summarize all the errors at the end after that anyway.All UIs are affected in the same way.
Cause
When an error happens, this line tells
NetAsyncModulesDownloader
:CKAN/Core/Net/NetAsyncDownloader.cs
Line 433 in 5b08975
... which then prints the exception with
User.RaiseError
.Changes
Now we put that stack trace into
log.Info
instead, so it won't be visible by default but you can re-enable it with--verbose
.