-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tags section of spec #2991
Conversation
I was wondering about the spec version for the tags. The spec isn't really clear in this case:
Would it make sense to set the spec version for tags back to v1.24 as it was originally in the #2034, when they where officially introduced in the schema? |
Yes, I see no perfect answer here.
|
Okay. I'd still lean more towards v1.27, because a reader can be sure that they are recognized from this version up, and the support in v1.26.8+ is basically a bonus. Otherwise we make v1.26.0 - v1.26.6 retroactively not conformant to the spec. |
d8f1f75
to
efcba4c
Compare
I think the idea is that the spec version is the minimum level of client that won't mess things up for a given element. Ignoring tags is perfectly correct behaviour. |
OK, I'm convinced. Changed to 1.27. |
@politas, which value would you recommend we use based on that? |
So we're making Bussard v1.27.0, then? |
That's also open to discussion. I was going to use 1.26.12, but it will be 1.27.0 if you say so. |
If we're bumping the spec, we should be bumping the client version to match, otherwise the client is not claiming to be compliant with the spec. |
That is assuming that we have tag support working in the client, now. We do, don't we? I haven't actually looked at that bit, myself. |
It was added in #2936, released in v1.26.8. |
We're not really bumping the spec version itself, just the version of one property is "in the future". But I guess making the next release v1.27 would solve most of that. |
Makes sense to me to make tags v1.27 in the spec and make Bussard v1.27.0. Let's go with that. |
Sounds good. This PR updates the spec to say tags are in 1.27, and Bussard will be 1.27.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, almost forgot to approve this PR then :D
The spec has a
tags
section, but it's mostly inaccurate and misleading. Now it's brought up to date with how the tags actually work.