Update Cake to 0.37.0 #2985
Merged
Update Cake to 0.37.0 #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows-compiled binaries work on Windows, so do Mono5-compiled ones. |
0d1e00a to
2bc9f67
Compare
|
Rebased on current master@10c2887a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We currently can't build with Cake on Mono 6.8, due to a rather complex issue I don't want to explain here, you can read it up in cake-build/cake#2695 and all the other issues that are linked there :P
Cake 0.37.0 fixed this.
Changes
This PR updates the Cake dependency from 0.36.0 to 0.37.0, now that it is released. This allows us to build CKAN using the build script on Mono 6.8 again.
(I guess Kate also automatically removed a BOM)
Note that I don't change back the Mono versions that we're using for the NetCore build on Travis. There's still the other problem, which makes Mono 6 compiled binaries not work on Windows or Mono 5, see #2976. Although we're not using that for anything release-related, let's play it conservatively for now.
I tested the compilation on Mono 6.8 and the exe runs.
We should also test compilation on Windows and running a Mono-compiled exe on Windows before merging, so we cover all the issues we encountered the last days.
I'm going to do this myself tomorrow, too.