Refresh Info.plist if changelog has changed #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The package for 1.26.8 on OSX apparently includes the right EXE, but the app bundle property says 1.26.6:
Cause
We had a snafu with Mono 6.6.0 in #2972, so all builds were regenerated by hand by @DasSkelett and replaced. Most likely he already had a file at
_build/osx/dmg/CKAN.app/Contents/Info.plistgenerated previously with 1.26.6 in it. When he checked out the commit for 1.26.8 and recompiled, this file was not regenerated.The
Makefiledirective forInfo.plistuses bothInfo.plist.inandCHANGELOG.md(indirectly via the$(VERSION)variable) to generate its output, but onlyInfo.plist.inis checked for changes currently.Changes
Now
Info.plistalso depends onCHANGELOG.md, so it will be regenerated when we build a new version.Fixes #2977.