Cache entirely based upon URLs. #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this fails, I expect it should succeed.
We can make IsCached much shorter, right?
Basic Store/Retrieve test on the new file cache.
* origin/master: NetKAN: Search Github assets to only download zipfile. ModuleManager can once again be installed. Test demonstrating bug in GetLeadingPathElements Further tests to ModuleInstaller. Added a disposable KSP manager for testing. More tests for path utils. Fixed the mess I made in ModuleInstaller Test: ModuleInstaller destination path Refactor KSP cloning functions to TestData class. Now removing leading parts of paths in FindInstallableFiles. Also added path utility methods (and tests) to KSPPathUtils
- NetCache no longer requires a temp dir. - No longer move files by default. - Fixed serious bug where our generated hashes could contain slashes. - NetCache is now file transaction aware.
* bugfix_i_broke_netkan: I brokez the NetKAN. This fixes it.
Previously we could get back a previously cached file from what we put in! Now we do the right thing and always remove old entries.
It still doesn't do anything useful on error. :(
|
Alas, this looks like it still has a bug, and somehow is managing to give files descriptive names which have nothing to do with their contents. The CKAN core is fine with this, but it confuses the hell outta us humans. |
Introduced in KSP-CKAN#287. Oops. Have tested with our mods that install to GameRoot, and they seem to be fine. Have not tested with tutorials. I think they're fine, but we may see another PR after this.
* fix_ships_installs: Fixed a bug where ships could no longer be installed.
This was harmless to CKAN operation, but sure made things confusing for humans.
|
Bug with wrong cache names fixed. Also incorporates #297 , so I could test installing oodles of mods. |
AlexanderDzhoganov
added a commit
that referenced
this pull request
Nov 9, 2014
Cache entirely based upon URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes and builds upon #282. Compared to it:
Our Async file operations still do a poor job of signalling errors, but that's a different issue.
Closes #111.