Show all recommendations of metapackages in GUI #2653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you use the "Install from .ckan..." menu option in GUI, as of #2577 some modules may be missing.
Cause
CanInstall
decides whether a list of modules can be installed by creating aRelationshipResolver
and checking whether its mod list has at least as many elements as it's trying to install:CKAN/GUI/MainRecommendations.cs
Line 152 in 1bbd2fd
The list on the right includes the .ckan file itself, which has
IsMetapackage = true
.Unfortunately
RelationshipResolver
excludes metapackages fromModList()
, so such modules would not be included on the left:CKAN/Core/Relationships/RelationshipResolver.cs
Lines 490 to 493 in 1bbd2fd
So
CanInstall
's check will fail when installing a metapackage, unless it has a bunch of extra dependencies.Changes
Now we exclude metapackages from the right side of that comparison, and all recommendations from the .ckan file are shown in GUI.
Fixes #2652.