Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building CKAN.app on macOS #2356

Merged
merged 3 commits into from
Mar 12, 2018
Merged

Conversation

phardy
Copy link
Contributor

@phardy phardy commented Mar 12, 2018

Implements the changes I suggested in #2355 for building the app bundle and disk image on macOS.

@HebaruSan
Copy link
Member

Nice! I think we'd need to change this instance of genisoimage to xorriso as well so Travis could handle the build:

CKAN/.travis.yml

Lines 18 to 33 in 624839f

addons:
apt:
packages:
- git
- mono-devel
- ca-certificates
# Stuff for building OSX DMGs
- make
- sed
- libplist-utils
- genisoimage
# Stuff for building .deb files
- gzip
- fakeroot
- dpkg
- lintian

Can you add that?

@HebaruSan HebaruSan added macOS Issues specific for macOS Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...) labels Mar 12, 2018
@phardy
Copy link
Contributor Author

phardy commented Mar 12, 2018

Oh, thanks. I had no idea that existed.

@HebaruSan
Copy link
Member

Thanks for the contribution!

@HebaruSan HebaruSan merged commit afb3ac4 into KSP-CKAN:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...) macOS Issues specific for macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants