Improve CKAN.app launch script #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
politas
added a commit
that referenced
this pull request
Mar 4, 2018
This was referenced Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The currently released CKAN.app opens the wiki page about installing on Mac when it can't find Mono. Currently that is every time, even if Mono is installed.
Cause
Non-ObjC app bundles on MacOSX are not provided:
/etc/paths.d/architecture for configuring it)We need both to run
mono ckan.exe, so we have to write code to figure them out at run time.The mono executable has lived in several different places on MacOSX, there's no way to just ask where it is, and our script previously only checked a path that was used in an older version of Mono.
The script's logic for finding its own folder was an overly complicated
awkscript that may or may not have worked.Changes
Now we check more places for the mono executable, by way of the
/etc/paths.d/mono-commandsfile.Now our logic for finding our folder is simplified; we use
dirname $0to find where the script lives, then wecdto that directory and runpwdto get its absolute path.Test build available.
Fixes #2307.