Don't crash if download_hash isn't set #2313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you try to install a mod that doesn't have a
download_hash
defined in its metadata, you might encounter this exception:Cause
We currently assume
download_hash
won't be null when checking for fallback URLs:CKAN/Core/Types/CkanModule.cs
Lines 631 to 641 in 9712f94
https://ksp.sarbian.com/ckan/MechJeb2-ci.tar.gz contains metadata for bleeding edge versions of MechJeb2, and it does not include the download_hash properties. This makes these modules uninstallable until this bug is fixed.
Changes
Now we check that
download_hash?.sha1
is not null before using it to provide a fallback URL.This allows such modules to download and install normally.
Fixes https://forum.kerbalspaceprogram.com/index.php?/topic/154922-ckan-the-comprehensive-kerbal-archive-network-v1240-bruce/&do=findComment&comment=3303984