Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle mod not found in versions tab #2303

Merged
merged 1 commit into from
Feb 24, 2018

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Feb 23, 2018

Problem

If your mod list is empty, it should auto refresh at launch as of #2241. However, an exception is thrown instead, with this stack trace:

CKAN.ModuleNotFoundKraken: Exception of type 'CKAN.ModuleNotFoundKraken' was thrown.
   at CKAN.Registry.AllAvailable(String module)
   at CKAN.MainAllModVersions.set_SelectedModule(GUIMod value)
   at CKAN.Main.ModList_SelectedIndexChanged(Object sender, EventArgs e)
   at System.Windows.Forms.DataGridView.OnSelectionChanged(EventArgs e)

You can click Continue and then Refresh to get past this, but it should be auto-refreshing instead.

Cause

MainAllModVersions.SelectedModule calls Registry.AllAvailable without handling ModuleNotFoundKraken.

Changes

Now we catch that exception, and the auto-refresh will work.

Fixes #2298.

@HebaruSan HebaruSan added Bug Something is not working as intended GUI Issues affecting the interactive GUI Pull request and removed Bug Something is not working as intended labels Feb 23, 2018
@politas politas merged commit 89fe7bf into KSP-CKAN:master Feb 24, 2018
politas added a commit that referenced this pull request Feb 24, 2018
@politas politas removed Bug Something is not working as intended Pull request labels Feb 24, 2018
@HebaruSan HebaruSan deleted the fix/empty-mod-list-exception branch February 24, 2018 07:37
@HebaruSan HebaruSan mentioned this pull request Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants