Print fewer download updates in headless mode #2256
Merged
+18
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When GPP updates, Jenkins has to download 181 MB of files. Since Cmdline currently prints a download status every 3 seconds, this results in most of the log looking like this:
https://ci.ksp-ckan.org/job/NetKAN/6759/consoleText
This time it went on for 15060 lines, and a total of 827 kilobytes, almost all of which is just clutter.
Changes
Now when netkan or ckan are running in headless mode, which Jenkins uses, they will only print a download progress update when the percentage changes (or less often, for very fast downloads). This will limit the number of lines to at most 100 while still logging the download.
I didn't reduce the number of updates coming from Core because these can be appropriate for making it clear that the GUI is still running.