Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print fewer download updates in headless mode #2256

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

HebaruSan
Copy link
Member

Problem

When GPP updates, Jenkins has to download 181 MB of files. Since Cmdline currently prints a download status every 3 seconds, this results in most of the log looking like this:

https://ci.ksp-ckan.org/job/NetKAN/6759/consoleText

1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           
1615 kbps - downloading - 98 MB left - 45%           

This time it went on for 15060 lines, and a total of 827 kilobytes, almost all of which is just clutter.

Changes

Now when netkan or ckan are running in headless mode, which Jenkins uses, they will only print a download progress update when the percentage changes (or less often, for very fast downloads). This will limit the number of lines to at most 100 while still logging the download.

I didn't reduce the number of updates coming from Core because these can be appropriate for making it clear that the GUI is still running.

@HebaruSan HebaruSan added Cmdline Issues affecting the command line Pull request Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...) labels Jan 16, 2018
@HebaruSan
Copy link
Member Author

Did we run out of CPU time on Travis?

@techman83
Copy link
Member

According to the status page:

Update - We are still investigating the job backlog incident.
Jan 17, 00:26 UTC

Current time is 00:34 UTC

@HebaruSan
Copy link
Member Author

Ahh interesting, it never occurred to me that they might be having an outage. Well now I can just watch that page. Thanks!

@politas politas merged commit c94b115 into KSP-CKAN:master Feb 13, 2018
@HebaruSan HebaruSan deleted the fix/download-log-spam branch February 13, 2018 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cmdline Issues affecting the command line Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants