Don't try to remove autodetected DLLs #2232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ckan remove --all
currently tries to remove autodetected DLLs, which fails. This makes this command unusable on Steam installs, which always have two extra DLLs,KSPSteamCtrlr
andSteamworks
.ckan remove --re regularexpression
has the same problem if the regular expressions match any autodetected DLL.Cause
Cmdline/Action/Remove.cs
loops overRegistry.Installed
, which includes autodetected DLLs:Changes
Now it uses
Registry.InstalledModules
, which does not include autodetected DLLs:Before
After
Linkages
Fixes #1553.